Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unused Entity private method #5029

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Replace unused Entity private method #5029

merged 1 commit into from
Aug 27, 2021

Conversation

paulbalandan
Copy link
Member

Description
The private method Entity::castAsJson() is only used in 4 tests but unused elsewhere. This swaps it with the dedicated castAs() method.

Checklist:

  • Securely signed commits
  • Unit testing, with >80% coverage

@paulbalandan paulbalandan mentioned this pull request Aug 26, 2021
Merged
1 task
@paulbalandan paulbalandan merged commit 7be28cd into codeigniter4:develop Aug 27, 2021
@paulbalandan paulbalandan deleted the entity-cast-as-json branch August 27, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulbalandan @MGatner